Re: [Qemu-devel] [PATCH V8 00/11] Add support for binding guest numa nodes to host numa nodes

[Paolo Bonzini]

Il 21/08/2013 11:34, Wanlong Gao ha scritto:
> On 08/21/2013 05:22 PM, Paolo Bonzini wrote:
>> Il 21/08/2013 11:08, Wanlong Gao ha scritto:
>>>>>> Also, do you still need a "-m" option if you use "-numa mem"?
>>>>>
>>>>> The "-m" options will be used to compute the memory size of each node
>>>>> if the memory size of each node is not set by "-numa mem" option. This
>>>>> is also be consistent with the original concept.
>>>>
>>>> Ok.  You didn't answer my exact question though---could you run the
>>>> above command line without "-m 2048"?
>>>
>>> Sorry :(
>>
>> No problem!
>>
>>> Sure not. And if the memory size assigned by "-m" option is not equal
>>> the total memory size assigned by "-numa mem,", the ACPI will write the
>>> wrong table, then the guest kernel will detect this and ignore the wrong
>>> ACPI numa table and assume that all of the memory are belong to one node.
>>
>> Can you make the code print a warning in this case, or fail to start the
>> VM (if there is "-numa mem" but the total doesn't match "-m"?
> 
> You mean this?  
> http://lists.nongnu.org/archive/html/qemu-devel/2013-05/msg03065.html
> I sent a patch previously to do this, if you like I can merge to this patch 
> set.

Yes!

>>
>>> Would you like to run without "-m" option in mind?
>>
>> This would definitely be nice to have, if it's not too complicated.
>> Otherwise, the above idea will do.
> 
> Yeah, but more complicated since we should make "-numa mem,size" and "-m"
> options both optional.

Yes.

Paolo