[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] monitor: print the invalid char in error mes
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] monitor: print the invalid char in error message |
|
Date: |
Tue, 20 Aug 2013 07:40:25 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 |
On 08/19/2013 08:58 PM, Fam Zheng wrote:
> It's more friendly to print which char is invalid to user, especially
> when user tries to input a float value and expect the monitor to round
> it to int. Since we don't round float number when we look for a integer,
> telling which char is invalid is less confusing.
Including a sample of the error message issued before and after this
patch as part of the commit message is helpful, but not enough for me to
require a respin.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> monitor.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature