Re: [Qemu-devel] [Bug?] qemu-1.6.0 python traceback in GEN qmp-commands.h

[Andreas Färber]

Am 16.08.2013 15:21, schrieb Peter Maydell:
> On 16 August 2013 08:59, Erik Rull <address@hidden> wrote:
>> Hi all,
>>
>> when using the released qemu-1.6.0.tar.bz2, I get the following error 
>> message:
>>   File "/home/erik/qemu-1.6.0/scripts/qapi.py", line 164
>>     except QAPISchemaError as e:
>>                             ^
>> SyntaxError: invalid syntax
>> make: *** [qmp-commands.h] Error 1
> 
> My guess is that your python is older than 2.6; I think
> the "except Foo as e" syntax is new in 2.6. We probably
> missed this because most people use a newer Python than
> 2.6, but configure's check only requires 2.4 or better.
> 
> We should probably update the scripts to not use overly
> new features (or alternatively decide that 2.6 is our new
> minimum -- what do RHEL5 and our other oldest-supported
> distros ship?)

I vaguely remember running into such problems before... possibly on
Solaris. We compiled a list of Python versions and I think settled for
2.4 based on some old RHEL, too. CC'ing Stefan.

git-blame points to:
http://repo.or.cz/w/qemu.git/commit/e120d449e1b39ec508c297b963ce452628dd37c3?f=configure

Andreas

> 
> For this specific case I think it needs to change to
>      except QAPISchemaError, e:
> 
> thanks
> -- PMM
> 


-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg