[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [qemu-devel]question on virtqueue_get_avail_bytes
From: |
yinyin |
Subject: |
[Qemu-devel] [qemu-devel]question on virtqueue_get_avail_bytes |
Date: |
Mon, 19 Aug 2013 17:28:44 +0800 |
Hi,all:
in func virtqueue_get_avail_bytes, when found a indirect desc, we need
loop over it.
/* loop over the indirect descriptor table */
indirect = 1;
max = vring_desc_len(desc_pa, i) / sizeof(VRingDesc);
num_bufs = i = 0;
desc_pa = vring_desc_addr(desc_pa, i);
But, It init i to 0, then use i to update desc_pa. so we will always
get :
desc_pa = vring_desc_addr(desc_pa, 0);
is it right?or should we update desc_pa first, then init i to 0?
diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
index 09f62c6..554ae6f 100644
--- a/hw/virtio/virtio.c
+++ b/hw/virtio/virtio.c
@@ -377,8 +377,8 @@ void virtqueue_get_avail_bytes(VirtQueue *vq, unsigned int
*in_bytes,
/* loop over the indirect descriptor table */
indirect = 1;
max = vring_desc_len(desc_pa, i) / sizeof(VRingDesc);
- num_bufs = i = 0;
desc_pa = vring_desc_addr(desc_pa, i);
+ num_bufs = i = 0;
}
do {
- [Qemu-devel] [qemu-devel]question on virtqueue_get_avail_bytes,
yinyin <=