[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/7] smbios cleanup & nicer defaults for type
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/7] smbios cleanup & nicer defaults for type 1 |
Date: |
Sat, 17 Aug 2013 06:50:04 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 |
On 08/17/2013 06:08 AM, Laszlo Ersek wrote:
> Eric,
>
> On 08/16/13 15:18, address@hidden wrote:
>> From: Markus Armbruster <address@hidden>
>>
>> This gets rid of one of the last get_param_value() users, makes
>> multiple -smbios work sanely, cleans up the gross side effect in
>> qemu_uuid_parse(), and more. Topped off with a little feature in the
>> last patch.
>>
>> v2: Rebase, only last patch had conflicts
>
> can you please re-ack this? You acked v2:
>
> http://thread.gmane.org/gmane.comp.emulators.qemu/222747
My prior review still stands. The series looks good to me.
>
> (And I don't have the slightest clue why it hasn't been merged after
> your Reviewed-by; it was posted, and reviewed, and pinged, before the
> hard freeze for 1.6)
I have no idea what happened either.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 3/7] smbios: Improve diagnostics for conflicting entries, (continued)
- [Qemu-devel] [PATCH v2 3/7] smbios: Improve diagnostics for conflicting entries, armbru, 2013/08/16
- [Qemu-devel] [PATCH v2 1/7] smbios: Normalize smbios_entry_add()'s error handling to exit(1), armbru, 2013/08/16
- [Qemu-devel] [PATCH v2 2/7] smbios: Convert to QemuOpts, armbru, 2013/08/16
- [Qemu-devel] [PATCH v2 4/7] smbios: Make multiple -smbios type= accumulate sanely, armbru, 2013/08/16
- [Qemu-devel] [PATCH v2 6/7] vl: Set current_machine early, armbru, 2013/08/16
- [Qemu-devel] [PATCH v2 5/7] smbios: Factor out smbios_maybe_add_str(), armbru, 2013/08/16
- [Qemu-devel] [PATCH v2 7/7] smbios: Set system manufacturer, product & version by default, armbru, 2013/08/16
- Re: [Qemu-devel] [PATCH v2 0/7] smbios cleanup & nicer defaults for type 1, Laszlo Ersek, 2013/08/17
- Re: [Qemu-devel] [PATCH v2 0/7] smbios cleanup & nicer defaults for type 1,
Eric Blake <=