[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 08/18] block/gluster: drop qemu_gluster_aio_flush
From: |
Bharata B Rao |
Subject: |
Re: [Qemu-devel] [PULL 08/18] block/gluster: drop qemu_gluster_aio_flush_cb() |
Date: |
Sat, 17 Aug 2013 10:52:34 +0530 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
> From: Stefan Hajnoczi <address@hidden>
> Since .io_flush() is no longer called we do not need
> qemu_gluster_aio_flush_cb() anymore. It turns out that qemu_aio_count
> is unused now and can be dropped.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
Tested-by: Bharata B Rao <address@hidden>
Tested GlusterFS backend, but it needed the below fix:
------
gluster: Remove the use of qemu_aio_count from gluster discard
qemu_aio_count is no longer used and hence remove its usage from
qemu_gluster_aio_discard()
Signed-off-by: Bharata B Rao <address@hidden>
---
block/gluster.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/block/gluster.c b/block/gluster.c
index fbdbe97..46f36f8 100644
--- a/block/gluster.c
+++ b/block/gluster.c
@@ -548,7 +548,6 @@ static BlockDriverAIOCB
*qemu_gluster_aio_discard(BlockDriverState *bs,
acb->size = 0;
acb->ret = 0;
acb->finished = NULL;
- s->qemu_aio_count++;
ret = glfs_discard_async(s->fd, offset, size, &gluster_finish_aiocb, acb);
if (ret < 0) {
@@ -557,7 +556,6 @@ static BlockDriverAIOCB
*qemu_gluster_aio_discard(BlockDriverState *bs,
return &acb->common;
out:
- s->qemu_aio_count--;
qemu_aio_release(acb);
return NULL;
}
- [Qemu-devel] [PULL 00/18] Block patches, Stefan Hajnoczi, 2013/08/16
- [Qemu-devel] [PULL 01/18] block: ensure bdrv_drain_all() works during bdrv_delete(), Stefan Hajnoczi, 2013/08/16
- [Qemu-devel] [PULL 02/18] block: stop relying on io_flush() in bdrv_drain_all(), Stefan Hajnoczi, 2013/08/16
- [Qemu-devel] [PULL 03/18] dataplane/virtio-blk: check exit conditions before aio_poll(), Stefan Hajnoczi, 2013/08/16
- [Qemu-devel] [PULL 04/18] tests: adjust test-aio to new aio_poll() semantics, Stefan Hajnoczi, 2013/08/16
- [Qemu-devel] [PULL 06/18] aio: stop using .io_flush(), Stefan Hajnoczi, 2013/08/16
- [Qemu-devel] [PULL 05/18] tests: adjust test-thread-pool to new aio_poll() semantics, Stefan Hajnoczi, 2013/08/16
- [Qemu-devel] [PULL 07/18] block/curl: drop curl_aio_flush(), Stefan Hajnoczi, 2013/08/16
- [Qemu-devel] [PULL 08/18] block/gluster: drop qemu_gluster_aio_flush_cb(), Stefan Hajnoczi, 2013/08/16
- [Qemu-devel] [PULL 09/18] block/iscsi: drop iscsi_process_flush(), Stefan Hajnoczi, 2013/08/16
- [Qemu-devel] [PULL 10/18] block/linux-aio: drop qemu_laio_completion_cb(), Stefan Hajnoczi, 2013/08/16
- [Qemu-devel] [PULL 11/18] block/nbd: drop nbd_have_request(), Stefan Hajnoczi, 2013/08/16
- [Qemu-devel] [PULL 12/18] block/rbd: drop qemu_rbd_aio_flush_cb(), Stefan Hajnoczi, 2013/08/16
- [Qemu-devel] [PULL 13/18] block/sheepdog: drop have_co_req() and aio_flush_request(), Stefan Hajnoczi, 2013/08/16
- [Qemu-devel] [PULL 14/18] block/ssh: drop return_true(), Stefan Hajnoczi, 2013/08/16
- [Qemu-devel] [PULL 15/18] dataplane/virtio-blk: drop flush_true() and flush_io(), Stefan Hajnoczi, 2013/08/16
- [Qemu-devel] [PULL 16/18] thread-pool: drop thread_pool_active(), Stefan Hajnoczi, 2013/08/16
- [Qemu-devel] [PULL 17/18] tests: drop event_active_cb(), Stefan Hajnoczi, 2013/08/16