Re: [Qemu-devel] [PATCH V5 4/5] block: Add support for throttling burst max in QMP and the command line.

[Stefan Hajnoczi]

On Mon, Aug 12, 2013 at 06:53:15PM +0200, Benoît Canet wrote:
> The max parameter of the leaky bycket throttling algoritm can be used to

s/bycket/bucket/
s/algoritm/algorithm/

> @@ -1098,7 +1112,19 @@ void hmp_block_set_io_throttle(Monitor *mon, const 
> QDict *qdict)
>                                qdict_get_int(qdict, "bps_wr"),
>                                qdict_get_int(qdict, "iops"),
>                                qdict_get_int(qdict, "iops_rd"),
> -                              qdict_get_int(qdict, "iops_wr"), &err);
> +                              qdict_get_int(qdict, "iops_wr"),
> +                              false, /* no burst max via QMP */

s/QMP/HMP/

> @@ -1758,6 +1770,12 @@ Each json-object contain the following:
>           - "iops": limit total I/O operations per second (json-int)
>           - "iops_rd": limit read operations per second (json-int)
>           - "iops_wr": limit write operations per second (json-int)
> +         - "bps_max":  total max in bytes(json-int)

Space before "(json-int)" and for the others new fields too.