[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/3] slirp: define timeout as macro
|
From: |
liu ping fan |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 2/3] slirp: define timeout as macro |
|
Date: |
Thu, 15 Aug 2013 08:33:28 +0800 |
On Wed, Aug 14, 2013 at 7:48 PM, Stefan Hajnoczi <address@hidden> wrote:
> On Wed, Aug 14, 2013 at 11:02:51AM +0800, Liu Ping Fan wrote:
>> @@ -47,6 +47,9 @@ static QTAILQ_HEAD(slirp_instances, Slirp) slirp_instances
>> =
>> static struct in_addr dns_addr;
>> static u_int dns_addr_time;
>>
>> +#define TIMEOUT_FAST 2
>> +#define TIMEOUT_SLOW 499
>
> #define TIMEOUT_FAST 2 /* milliseconds */
>
> Actually I'm not sure what the units are but please document them,
> either as a comment or call the macro itself TIMEOUT_FAST_MS.
Yes, its unit is milliseconds for g_poll(). Will document them.
Thx,
Pingfan