[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] slirp: Port redirection option behave different
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] slirp: Port redirection option behave differently on Linux and Windows |
|
Date: |
Wed, 14 Aug 2013 10:08:14 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130805 Thunderbird/17.0.8 |
On 08/14/2013 09:49 AM, Taimoor Mirza wrote:
> On Wed, Aug 14, 2013 at 2:20 AM, Eric Blake <address@hidden> wrote:
>> On 08/13/2013 03:05 PM, Taimoor wrote:
>>> From: Taimoor Mirza <address@hidden>
>>>
>>> port redirection code uses SO_REUSEADDR socket option before binding to
>>> host port. Behavior of SO_REUSEADDR is different on Windows and Linux.
>>> Relaunching QEMU with same host and guest port redirection values on Linux
>>> throws error but on Windows it does not throw any error.
>>> Problem is discussed in
>>> http://lists.gnu.org/archive/html/qemu-devel/2013-04/msg03089.html
>>
>> When resending a patch, please use a v2 in the subject line (git
>> send-email --subject-prefix PATCHv2), send as a top-level thread, and
>> include a changelog after the --- divider that explains what changed
>> from v1. See http://wiki.qemu.org/Contribute/SubmitAPatch for more hints.
>
>
> Thanks Eric. Should I resend with changelog of v2 and v2 in subject line?
Yes, doing so will give it better visibility.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature