|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [PATCH v2 1/4] seqlock: introduce read-write seqlock |
Date: | Tue, 13 Aug 2013 16:52:04 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 |
Il 13/08/2013 11:09, Jan Kiszka ha scritto: >>>> >>> >>> >> >>> >> As the usage pattern is >>> >> >>> >> seqlock_read_begin() >>> >> do >>> >> ... >>> >> while (seqlock_read_check()) >>> >> >>> >> I would suggest to call the latter seqlock_read_retry(), just like the >>> >> kernel does. >>> >> >> > I think it contains the meaning of check-success-or-retry. So may >> > check be nicer? > "Check" alone has no obvious semantic for me, therefore "retry". I agree. I was writing the patch without looking at any Linux code (just to be safe since it's GPLv2-only) and misremembered the name of the API. Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |