Re: [Qemu-devel] [RFC] [PATCHv8 09/30] aio / timers: Add QEMUTimerListGroup and helper functions

[Paolo Bonzini]

Il 10/08/2013 13:05, Alex Bligh ha scritto:
> Despite the fact we both dislike the name TimerListGroup, I
> think the way to go here is (1). (2) does not really save lines
> of code (certainly not compiled instructions) - it's main saving
> is removing a pile of commenting from include/qemu/timer.h,
> which makes things more opaque.
> 
> I also think there may well be a use for something that wants
> to use timers but not AioContext (I am thinking for instance
> of a thread that does not do block IO). This permits that,
> but does not require it.

There is actually a disadvantage of moving TimerListGroup to AioContext.
 The disadvantage is that GSources can only work with millisecond
resolution.  Thus you would need anyway some special casing of the
"timer AioContext" to get the deadline in nanoseconds.

So let's keep the TimerListGroup for now.

Paolo

> WDYT?