Re: [Qemu-devel] [PATCH v2 for-1.6 6/6] rdma: remaining documentation fixes

[Michael R. Hines]

On 08/09/2013 04:26 PM, Eric Blake wrote:
> On 08/09/2013 02:05 PM, address@hidden wrote:
> > From: "Michael R. Hines" <address@hidden>
> >
> > Was missing 'setup-time' in some of the QMP documentation...
> >
> > Signed-off-by: Michael R. Hines <address@hidden>
> > ---
> >   qmp-commands.hx |   10 ++++++++++
> >   1 file changed, 10 insertions(+)
> Reviewed-by: Eric Blake <address@hidden>
>
> > @@ -2742,6 +2751,7 @@ Examples:
> >               "remaining":1053304,
> >               "transferred":3720,
> >               "total-time":12345,
> > +            "setup-time":12345,
> Theoretically, if setup-time == total-time, then we are still in the
> setup phase, right?  The example might be more realistic if it uses a
> smaller number for setup time.  But at the end of the day, I don't
> actually care enough to force a respin, when we are this close to the
> 1.6 deadline and this deserves to be in 1.6.

Ooops - well, when I was reading the file - all the numbers seemed like 
place-holders, not realistic numbers.

This documentation is kind of hard to maintain in the first place - 
something like this is more the job of a tool like 'virt-test' which 
could actually exercise QMP and dump the output during a test cycle in 
case the user actually wanted to see what the migration life cycle 
actually looks like.

- Michael