Re: [Qemu-devel] [RFC] [PATCHv8 13/30] aio / timers: Add aio_timer_new wrapper

[Alex Bligh]

On 9 Aug 2013, at 15:51, Paolo Bonzini wrote:

>> One nit:
>> 
>> Currently struct QEMUTimer lives nicely within qemu_timer.c, hidden
>> from the .h, which only contains:
>>  typedef struct QEMUTimer QEMUTimer;
>> 
>> If what you are after is for people to put a QEMUTimer into their
>> struct, rather than a QEMUTimer * (and hopefully to remember to
>> put qemu_timer_init in!) then I need to move the whole of the
>> declaration of the struct to the .h file which is a bit yucky.
> 
> Yeah, that's fine.  We're not relying too much on opaque types anyway.

Out of interest, there was some talk about modular block drivers
(i.e. loading them at run time). If we do that, we'll need a stable
API, and this would be a move in the wrong direction.

-- 
Alex Bligh