[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC] [PATCHv8 28/30] aio / timers: Add scripts/switch-
From: |
Alex Bligh |
Subject: |
Re: [Qemu-devel] [RFC] [PATCHv8 28/30] aio / timers: Add scripts/switch-timer-api |
Date: |
Fri, 9 Aug 2013 15:35:24 +0100 |
On 9 Aug 2013, at 11:26, Paolo Bonzini wrote:
> Il 08/08/2013 23:42, Alex Bligh ha scritto:
>> + # these have just changed name
>> + $line =~ s/\bqemu_mod_timer\b/qemu_timer_mod/g;
>> + $line =~ s/\bqemu_mod_timer_(ns|us|ms)\b/qemu_timer_mod_$1/g;
>> + $line =~ s/\bqemu_free_timer\b/qemu_timer_free/g;
>> + $line =~ s/\bqemu_del_timer\b/qemu_timer_del/g;
>
> I couldn't quite track which patch introduced this change.
>
> I would either go all the way and drop the qemu_ prefix, or leave the
> old name in place.
As per previous comment, they can't stay the same because at various
stages in the process both apis are used. If we don't want to keep
qemu_timer_ for the static situation, I suggest we just go to timer_.
--
Alex Bligh
[Qemu-devel] [RFC] [PATCHv8 30/30] aio / timers: Remove legacy interface, Alex Bligh, 2013/08/08
Re: [Qemu-devel] [RFC] [PATCHv8 00/30] aio / timers: Add AioContext timers and use ppoll, Alex Bligh, 2013/08/08
Re: [Qemu-devel] [RFC] [PATCHv8 00/30] aio / timers: Add AioContext timers and use ppoll, Jan Kiszka, 2013/08/09
Re: [Qemu-devel] [RFC] [PATCHv8 00/30] aio / timers: Add AioContext timers and use ppoll, Stefan Hajnoczi, 2013/08/09