[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] memory: Return -1 again on reads from unsigned
|
From: |
Jan Kiszka |
|
Subject: |
Re: [Qemu-devel] [PATCH] memory: Return -1 again on reads from unsigned regions |
|
Date: |
Thu, 08 Aug 2013 17:31:46 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2013-08-08 17:13, Peter Maydell wrote:
> On 16 July 2013 13:45, Jan Kiszka <address@hidden> wrote:
>> This restore the behavior prior to b018ddf633 which accidentally changed
>> the return code to 0. Specifically guests probing for register existence
>> were affected by this.
>>
>> Signed-off-by: Jan Kiszka <address@hidden>
>
> For the record (I know you have a revert-patch on the list)
> this patch breaks the 'musicpal' platform (my test image
> no longer boots with this change).
Yes, that's how I finally found out as well that this patch was wrong.
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux