[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC] [PATCHv7 01/22] aio / timers: Add qemu_clock_free
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [RFC] [PATCHv7 01/22] aio / timers: Add qemu_clock_free and expose qemu_clock_new and clock types |
Date: |
Wed, 7 Aug 2013 13:31:07 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Aug 07, 2013 at 12:48:55AM +0100, Alex Bligh wrote:
> Add qemu_clock_free and expose qemu_new_clock as qemu_clock_new.
>
> Expose clock types.
>
> Signed-off-by: Alex Bligh <address@hidden>
> ---
> include/qemu/timer.h | 22 ++++++++++++++++++++++
> qemu-timer.c | 11 ++++++-----
> 2 files changed, 28 insertions(+), 5 deletions(-)
Regarding doc comments: if the function is self-documenting then the doc
comment might not add much. I think in those cases it's okay to omit
details about arguments or return values if they are clear from the
function prototype.
Reviewed-by: Stefan Hajnoczi <address@hidden>
- [Qemu-devel] [RFC] [PATCHv7 00/22] aio / timers: Add AioContext timers and use ppoll, Alex Bligh, 2013/08/06
- [Qemu-devel] [RFC] [PATCHv7 02/22] aio / timers: add qemu-timer.c utility functions, Alex Bligh, 2013/08/06
- [Qemu-devel] [RFC] [PATCHv7 03/22] aio / timers: Consistent treatment of disabled clocks for deadlines, Alex Bligh, 2013/08/06
- [Qemu-devel] [RFC] [PATCHv7 04/22] aio / timers: add ppoll support with qemu_poll_ns, Alex Bligh, 2013/08/06
- [Qemu-devel] [RFC] [PATCHv7 05/22] aio / timers: Add prctl(PR_SET_TIMERSLACK, 1, ...) to reduce timer slack, Alex Bligh, 2013/08/06
- [Qemu-devel] [RFC] [PATCHv7 06/22] aio / timers: Make qemu_run_timers and qemu_run_all_timers return progress, Alex Bligh, 2013/08/06