[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/3] rdma: validate remote provided RDMAControlH
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 0/3] rdma: validate remote provided RDMAControlHeader::len |
Date: |
Wed, 7 Aug 2013 03:40:28 -0400 (EDT) |
> RDMAControlHeader::len is remote-provided. So validate the value before use.
>
> Isaku Yamahata (3):
> rdma: use resp.len after validation in qemu_rdma_registration_stop
> rdma: validate RDMAControlHeader::len
> rdma: check if RDMAControlHeader::len match transferred byte
>
> migration-rdma.c | 44 ++++++++++++++++++++++++++++++--------------
> 1 file changed, 30 insertions(+), 14 deletions(-)
Looks good, thanks!
We will have a mix of assertions and errors after this patch.
Asserting on the destination is probably okay, but as a follow-up
perhaps we can change the assertion(s) to errors.
Paolo
- [Qemu-devel] [PATCH 0/3] rdma: validate remote provided RDMAControlHeader::len, Isaku Yamahata, 2013/08/06
- [Qemu-devel] [PATCH 2/3] rdma: validate RDMAControlHeader::len, Isaku Yamahata, 2013/08/06
- [Qemu-devel] [PATCH 3/3] rdma: check if RDMAControlHeader::len match transferred byte, Isaku Yamahata, 2013/08/06
- [Qemu-devel] [PATCH 1/3] rdma: use resp.len after validation in qemu_rdma_registration_stop, Isaku Yamahata, 2013/08/06
- Re: [Qemu-devel] [PATCH 0/3] rdma: validate remote provided RDMAControlHeader::len,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH 0/3] rdma: validate remote provided RDMAControlHeader::len, Orit Wasserman, 2013/08/07
- Re: [Qemu-devel] [PATCH 0/3] rdma: validate remote provided RDMAControlHeader::len, Michael R. Hines, 2013/08/07
- Re: [Qemu-devel] [PATCH 0/3] rdma: validate remote provided RDMAControlHeader::len, Anthony Liguori, 2013/08/14