[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 for-1.6] mips: revert commit b332d24a8e129095
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 for-1.6] mips: revert commit b332d24a8e1290954029814d09156b06ede358e2 |
|
Date: |
Tue, 06 Aug 2013 13:35:12 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 |
Am 06.08.2013 13:08, schrieb Aurelien Jarno:
> Now that this code path is not triggered anymore during the tests,
> revert commit b332d24a8e1290954029814d09156b06ede358e2. Booting a MIPS
> target without kernel nor bios doesn't really make sense. At the same
> time replace fprintf(stderr, ...) by error_report().
>
> Signed-off-by: Aurelien Jarno <address@hidden>
> ---
> hw/mips/mips_fulong2e.c | 4 +++-
> hw/mips/mips_jazz.c | 5 +++--
> hw/mips/mips_malta.c | 7 ++++---
> hw/mips/mips_mipssim.c | 7 ++++---
> 4 files changed, 14 insertions(+), 9 deletions(-)
>
> v1 -> v2: replace fprintf(stderr, ...) by error_report()
If you drop the two remaining \n then feel free to commit with my
Reviewed-by.
Thanks,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg