[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: add missing .bdrv_has_zero
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [sheepdog] [PATCH] sheepdog: add missing .bdrv_has_zero_init |
Date: |
Tue, 6 Aug 2013 10:24:42 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 06.08.2013 um 09:37 hat MORITA Kazutaka geschrieben:
> At Tue, 6 Aug 2013 14:44:37 +0800,
> Liu Yuan wrote:
> >
> > Cc: Kevin Wolf <address@hidden>
> > Cc: Stefan Hajnoczi <address@hidden>
> > Signed-off-by: Liu Yuan <address@hidden>
> > ---
> > block/sheepdog.c | 2 ++
> > 1 file changed, 2 insertions(+)
>
> Reviewed-by: MORITA Kazutaka <address@hidden>
The commit message is lacking. Added this description:
Commit 3ac21627 changed the behaviour of bdrv_has_zero_init() to default
to 0. In the review for Sheepdog it turned out that enabling it is safe,
so that commit updated one BlockDriver definition of sheepdog to use
bdrv_has_zero_init_1, missed however that there are more BlockDrivers in
the driver. Fix these now.
And applied the patch to the block branch.
Kevin