[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 01/10] vmdk: remove ret from inner scope.
From: |
Fam Zheng |
Subject: |
[Qemu-devel] [PATCH v4 01/10] vmdk: remove ret from inner scope. |
Date: |
Tue, 6 Aug 2013 15:44:46 +0800 |
A inner scope "ret" variable hides the real return code, it will always
return VMDK_OK for bs->backing_hd. Fix this by removing the declaration.
Signed-off-by: Fam Zheng <address@hidden>
---
block/vmdk.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index 3756333..f42657b 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -813,8 +813,8 @@ static int get_whole_cluster(BlockDriverState *bs,
/* we will be here if it's first write on non-exist grain(cluster).
* try to read from parent image, if exist */
if (bs->backing_hd) {
- int ret;
-
+ whole_grain =
+ qemu_blockalign(bs, extent->cluster_sectors << BDRV_SECTOR_BITS);
if (!vmdk_is_cid_valid(bs)) {
return VMDK_ERROR;
}
--
1.8.3.4
- [Qemu-devel] [PATCH v4 00/10] vmdk: Input validation fixes, Fam Zheng, 2013/08/06
- [Qemu-devel] [PATCH v4 01/10] vmdk: remove ret from inner scope.,
Fam Zheng <=
- [Qemu-devel] [PATCH v4 02/10] vmdk: Make VMDK3Header and VmdkGrainMarker QEMU_PACKED, Fam Zheng, 2013/08/06
- [Qemu-devel] [PATCH v4 03/10] vmdk: use unsigned values for on disk header fields, Fam Zheng, 2013/08/06
- [Qemu-devel] [PATCH v4 04/10] qemu-iotests: add poke_file utility function, Fam Zheng, 2013/08/06
- [Qemu-devel] [PATCH v4 05/10] qemu-iotests: add empty test case for vmdk, Fam Zheng, 2013/08/06
- [Qemu-devel] [PATCH v4 06/10] vmdk: check granularity field in opening, Fam Zheng, 2013/08/06
- [Qemu-devel] [PATCH v4 07/10] vmdk: check l2 table size when opening, Fam Zheng, 2013/08/06
- [Qemu-devel] [PATCH v4 08/10] vmdk: check l1 size before opening image, Fam Zheng, 2013/08/06
- [Qemu-devel] [PATCH v4 09/10] vmdk: use heap allocation for whole_grain, Fam Zheng, 2013/08/06