[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [SeaBIOS] [PATCH] don't expose pvpanic device in the UI
From: |
Gleb Natapov |
Subject: |
Re: [Qemu-devel] [SeaBIOS] [PATCH] don't expose pvpanic device in the UI |
Date: |
Tue, 6 Aug 2013 10:34:06 +0300 |
On Mon, Aug 05, 2013 at 09:32:18PM +0300, Michael S. Tsirkin wrote:
> > > As you see we do let people change many parameters
> > > that do affect activation.
> > By editing XML user can shoot himself in the foot, we should not prevent
> > that.
>
> So that's what I'm saying basically.
> At the moment there's no way to remove this device from XML.
> That's just wrong.
Can say the same about PV acpi hotpulg device.
> In QEMU, we have a standard way to specify devices with -device.
> That should be the interface for anything new really
> unless there's a very compelling reason for something else.
We are disagree on compelling reason in this case obviously.
> *Not* building it into the PC machine type.
>
> > It should not be required though.
>
> libvirt can pass -device pvpanic by default if nothing
> is specified in XML. That discussion really has to happen
> on libvirt list.
>
As Paolo said you are just pushing the "problem" up the stack
where it is harder to "solve". I put "problem" and "solve" in
quotes because I disagree that the problem that need to be solved
is identified correctly. The correct problem to be solved IMO is
writing Windows driver for the device.
--
Gleb.