[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-1.6] target-i386: Fix X86CPU error handling
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-devel] [PATCH for-1.6] target-i386: Fix X86CPU error handling |
|
Date: |
Mon, 05 Aug 2013 14:06:07 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 |
Am 02.08.2013 19:22, schrieb Andreas Färber:
> Error **errp argument is not for emitting warnings, it means an error
> has occurred and the caller should not make any assumptions about the
> state of other return values (unless otherwise documented).
>
> Therefore cpu_x86_create() must unref the new X86CPU itself, and
> pc_new_cpu() must check for an Error rather than NULL return value.
>
> While at it, clean up a superfluous NULL check.
>
> Reported-by: Jan Kiszka <address@hidden>
> Cc: address@hidden
> Cc: Igor Mammedov <address@hidden>
> Signed-off-by: Andreas Färber <address@hidden>
Ping! Jan, does this address your concerns / use cases?
-rc2 is on Wednesday.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg