Re: [Qemu-devel] [ANNOUNCE] QEMU 1.6.0-rc1 is now available

[Laszlo Ersek]

On 08/04/13 14:17, Mark Cave-Ayland wrote:
> On 01/08/13 23:08, Anthony Liguori wrote:
> 
>> Hi,
>>
>> On behalf of the QEMU Team, I'd like to announce the availability of the
>> second release candidate for the QEMU 1.6 release.  This release is meant
>> for testing purposes and should not be used in a production environment.
>>
>> http://wiki.qemu.org/download/qemu-1.6.0-rc1.tar.bz2
> 
> Hi Anthony,
> 
> There are still two outstanding issues from my testing here - patches
> have been submitted for both, but not applied yet.
> 
> - qemu-system-sparc64 broken
> See https://lists.gnu.org/archive/html/qemu-devel/2013-07/msg05201.html.
> 
> - OpenBIOS images have not been updated
> See https://lists.gnu.org/archive/html/qemu-devel/2013-07/msg05923.html.

Also, my series

  [PATCH 0/4] dump-guest-memory: correct the vmcores
  http://thread.gmane.org/gmane.comp.emulators.qemu/225360

was dropped from qmp-1.6 (and consequently didn't make the d5a2bcf7
merge) due to an asynchronous change to another part of the tree that I
could not have foreseen.

IOW it was not my fault -- I did exercise due diligence and my series
was building and working fine at the then-fresh master when I posted it.
A conflicting function was introduced between my posting and Luiz's
application of my series to his qmp-1.6 branch, and since I was on PTO
from last Thursday, I could only refresh the series only today.

The update from v1 to v2 is trivial:


diff --git a/target-s390x/arch_dump.c b/target-s390x/arch_dump.c
index f3e5144..9d36116 100644
--- a/target-s390x/arch_dump.c
+++ b/target-s390x/arch_dump.c
@@ -176,7 +176,8 @@ int s390_cpu_write_elf64_note(WriteCoreDumpFunction f, 
CPUState *cs,
     return s390x_write_all_elf64_notes("CORE", f, cpu, cpuid, opaque);
 }

-int cpu_get_dump_info(ArchDumpInfo *info)
+int cpu_get_dump_info(ArchDumpInfo *info,
+                      const struct GuestPhysBlockList *guest_phys_blocks)
 {
     info->d_machine = EM_S390;
     info->d_endian = ELFDATA2MSB;


Please do consider it for 1.6, it addresses a serious bug (= vmcores saved
with dump-guest-memory/paging=false are broken for > 3.5G x86(_64) guests).

  [PATCH v2 for-qmp-1.6 0/4] dump-guest-memory: correct the vmcores
  http://thread.gmane.org/gmane.comp.emulators.qemu/226378

Thanks
Laszlo