Re: [Qemu-devel] [sheepdog] [PATCH v4 06/10] coroutine: add co_aio_sleep_ns() to allow sleep in block drivers

[Alex Bligh]

Pingfan,

--On 2 August 2013 16:19:31 +0800 liu ping fan <address@hidden> wrote:

> > Okay, I'll update this patch based on the AioContext timer.  I'm also
> > happy to help Alex and Pingfan to finish the implementation.
> Alex, do you make a further step than V4? If you have, could you share
> it with us?So we can rebase our patches onto yours.

I've got no changes beyond v4 yet.

The changes I am thinking of making are:

1. changing the AioContext * in QEMUTimerList to be a pointer to a callback
  instead. This is a tiny and self-contained change and may well be
  unnecessary.

2. Whatever comes out of Paolo's long email of yesterday, the contents of
  which I have not fully digested. However, I think what this boils down
  to is calling *_notify slightly less often.

3. Someone (Paolo/Kevin?) suggested renaming the *new* timer functions
  (i.e. the ones with timerlist in the name). That won't affect anything
  current.

I suggest you go with v4 for the time being. If I end up doing a v5 and
your code doesn't sit well on top of it, I can rebase to yours or
something. I'd expect changes in v5 to be really small.

--
Alex Bligh