Re: [Qemu-devel] [PATCH 02/16] vl: set default ram_size during variable initialization

[Andreas Färber]

Am 23.07.2013 18:22, schrieb Igor Mammedov:
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
>  vl.c |    7 +------
>  1 files changed, 1 insertions(+), 6 deletions(-)
> 
> diff --git a/vl.c b/vl.c
> index 8190504..bf0c658 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2947,7 +2947,7 @@ int main(int argc, char **argv, char **envp)
>      module_call_init(MODULE_INIT_MACHINE);
>      machine = find_default_machine();
>      cpu_model = NULL;
> -    ram_size = 0;
> +    ram_size = DEFAULT_RAM_SIZE * 1024 * 1024;
>      snapshot = 0;
>      cyls = heads = secs = 0;
>      translation = BIOS_ATA_TRANSLATION_AUTO;
> @@ -4064,11 +4064,6 @@ int main(int argc, char **argv, char **envp)
>          exit(1);
>      }
>  
> -    /* init the memory */
> -    if (ram_size == 0) {
> -        ram_size = DEFAULT_RAM_SIZE * 1024 * 1024;
> -    }
> -
>      if (qemu_opts_foreach(qemu_find_opts("device"), device_help_func, NULL, 
> 0)
>          != 0) {
>          exit(0);

Commit message doesn't give any explanation why?

What happens with -m 0? My guess is the old code translates that to the
default size, where by intializing the default earlier it would stay.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg