[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V2 for-1.6 1/5] block: Repair the throttling cod
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH V2 for-1.6 1/5] block: Repair the throttling code. |
Date: |
Tue, 23 Jul 2013 16:31:13 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Jul 23, 2013 at 02:21:03PM +0200, Benoît Canet wrote:
> The throttling code was segfaulting since commit
> 02ffb504485f0920cfc75a0982a602f824a9a4f4 because some qemu_co_queue_next
> caller
> does not run in a coroutine.
> qemu_co_queue_do_restart assume that the caller is a coroutinne.
> As sugested by Stefan fix this by entering the coroutine directly.
Please mark qemu_co_queue_next() and qemu_co_queue_restart_all()
coroutine_fn. They may only be called from coroutine context.
Also please add assert(qemu_in_coroutine()) to these functions so an
assertion fires when they are used incorrectly.
- [Qemu-devel] [PATCH V2 for-1.6 0/5] Leaky bucket throttling and features, Benoît Canet, 2013/07/23
- [Qemu-devel] [PATCH V2 for-1.6 1/5] block: Repair the throttling code., Benoît Canet, 2013/07/23
- Re: [Qemu-devel] [PATCH V2 for-1.6 1/5] block: Repair the throttling code.,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH V2 for-1.6 3/5] block: Add support for throttling burst threshold in QMP and the co mmand line., Benoît Canet, 2013/07/23
- [Qemu-devel] [PATCH V2 for-1.6 2/5] block: Modify the throttling code to implement the leaky bucket algorithm., Benoît Canet, 2013/07/23
- [Qemu-devel] [PATCH V2 for-1.6 4/5] block: Add iops_sector_count to do the iops accounting for a gi ven io size., Benoît Canet, 2013/07/23
- [Qemu-devel] [PATCH V2 for-1.6 5/5] block: Add throttling percentage metrics., Benoît Canet, 2013/07/23