[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 2/8] i.MX: Implement a more complete version of t
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PULL 2/8] i.MX: Implement a more complete version of the GPT timer. |
Date: |
Wed, 26 Jun 2013 23:15:05 +0100 |
On 26 June 2013 22:57, Jean-Christophe DUBOIS <address@hidden> wrote:
> Names don't feel really useful in the second case as they are
> indistinguishable. Is the consensus around "generic" names (like MMIO or
> "Ctrl regs") without adding reference to the device a good one for all
> platforms?
Just leave the memory region and vmstate names as they
were before your patches.
(Personally I think it's entirely fine to include the device
name in the memory region name. These strings are for debugging,
so if I print region->name in my debugger it's much more helpful
if it says "imx-serial" than if it just says "regs".)
-- PMM
- Re: [Qemu-devel] [PULL 2/8] i.MX: Implement a more complete version of the GPT timer., (continued)
- Re: [Qemu-devel] [PULL 2/8] i.MX: Implement a more complete version of the GPT timer., Peter Maydell, 2013/06/25
- Re: [Qemu-devel] [PULL 2/8] i.MX: Implement a more complete version of the GPT timer., Paolo Bonzini, 2013/06/26
- Re: [Qemu-devel] [PULL 2/8] i.MX: Implement a more complete version of the GPT timer., jcd, 2013/06/26
- Re: [Qemu-devel] [PULL 2/8] i.MX: Implement a more complete version of the GPT timer., Paolo Bonzini, 2013/06/26
- Re: [Qemu-devel] [PULL 2/8] i.MX: Implement a more complete version of the GPT timer., jcd, 2013/06/26
- Re: [Qemu-devel] [PULL 2/8] i.MX: Implement a more complete version of the GPT timer., Peter Crosthwaite, 2013/06/26
- Re: [Qemu-devel] [PULL 2/8] i.MX: Implement a more complete version of the GPT timer., Jean-Christophe DUBOIS, 2013/06/26
- Re: [Qemu-devel] [PULL 2/8] i.MX: Implement a more complete version of the GPT timer., Jean-Christophe DUBOIS, 2013/06/26
- Re: [Qemu-devel] [PULL 2/8] i.MX: Implement a more complete version of the GPT timer., Paolo Bonzini, 2013/06/26
- Re: [Qemu-devel] [PULL 2/8] i.MX: Implement a more complete version of the GPT timer., Jean-Christophe DUBOIS, 2013/06/26
- Re: [Qemu-devel] [PULL 2/8] i.MX: Implement a more complete version of the GPT timer.,
Peter Maydell <=
- Re: [Qemu-devel] [PULL 2/8] i.MX: Implement a more complete version of the GPT timer., Jean-Christophe DUBOIS, 2013/06/26
- Re: [Qemu-devel] [PULL 2/8] i.MX: Implement a more complete version of the GPT timer., Peter Maydell, 2013/06/27
- Re: [Qemu-devel] [PULL 2/8] i.MX: Implement a more complete version of the GPT timer., Andreas Färber, 2013/06/26
- [Qemu-devel] [PULL 5/8] i.MX31: Fix PRCS bit test, Peter Maydell, 2013/06/25
- [Qemu-devel] [PULL 6/8] block/nand: QOM casting sweep, Peter Maydell, 2013/06/25
- Re: [Qemu-devel] [PULL 0/8] arm-devs queue, Anthony Liguori, 2013/06/25