qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH qom-cpu v2 18/29] cpu: Turn cpu_unassigned_acces

From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH qom-cpu v2 18/29] cpu: Turn cpu_unassigned_access() into a CPUState hook
Date: Mon, 17 Jun 2013 13:34:45 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130514 Thunderbird/17.0.6 
On 06/16/2013 08:57 AM, Andreas Färber wrote:
> +        cpu = CPU(alpha_env_get_cpu(cpu_single_env));
> +        cs = CPU(alpha_env_get_cpu(cpu_single_env));
> +    CPUState *cpu_single_cpu = CPU(alpha_env_get_cpu(cpu_single_env));
> +        cs = CPU(alpha_env_get_cpu(cpu_single_env));

ENV_GET_CPU.

> +    cpu_class_set_do_unassigned_access(cc, alpha_cpu_unassigned_access);

Wouldn't it be better to arrange for the function to exist always, with
differing implementation for user and system, much like do_interrupt?

What you've got is good enough for now, I suppose.


r~
reply via email to
[Prev in Thread] Current Thread [Next in Thread]