[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/3] block: add block_backup QMP command
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 2/3] block: add block_backup QMP command |
Date: |
Mon, 29 Apr 2013 11:27:01 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130311 Thunderbird/17.0.4 |
Il 29/04/2013 09:21, Stefan Hajnoczi ha scritto:
> > I'd really love to see us change 'BlockJobInfo' to use an enum for
> > 'type', instead of its open-coded 'str'. Likewise, the block-job
> > related events in QMP/qmp-events.txt should be updated to refer to the
> > enum instead of also being open-coded 'str'.
>
> Since the block job QMP API has been in released I'm not sure changing
> this is worthwhile. QEMU and libvirt would have to maintain
> compatibility so the code will just be duplicated.
I don't think this would change the actual data on the wire. However,
it would let libvirt know the supported block job types by introspecting
the enum.
Paolo
- [Qemu-devel] [PATCH 0/3] block: block-backup live backup command, Stefan Hajnoczi, 2013/04/23
- [Qemu-devel] [PATCH 1/3] block: add basic backup support to block driver, Stefan Hajnoczi, 2013/04/23
- [Qemu-devel] [PATCH 3/3] qemu-iotests: add 054 block-backup test case, Stefan Hajnoczi, 2013/04/23
- [Qemu-devel] [PATCH 2/3] block: add block_backup QMP command, Stefan Hajnoczi, 2013/04/23
- Re: [Qemu-devel] [PATCH 0/3] block: block-backup live backup command, Eric Blake, 2013/04/23
- Re: [Qemu-devel] [PATCH 0/3] block: block-backup live backup command, Wenchao Xia, 2013/04/27