[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 12/15] target-ppc: Refactor debug output macr
|
From: |
Alexander Graf |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 12/15] target-ppc: Refactor debug output macros |
|
Date: |
Mon, 25 Feb 2013 13:54:34 +0100 |
On 21.02.2013, at 05:25, Andreas Färber wrote:
> Make debug output compile-testable even if disabled.
>
> Rename dprintf() in kvm.c to kvm_dprintf() to avoid conflict with glibc.
>
> Inline DEBUG_OP check in excp_helper.c.
> Inline LOG_MMU_STATE() in mmu_helper.c.
> Inline PPC_{DEBUG_SPR,DUMP_SPR_ACCESSES} checks in translate_init.c.
>
> Signed-off-by: Andreas Färber <address@hidden>
I assume you verified that all the bits do get optimized out, right? :)
Reviewed-by: Alexander Graf <address@hidden>
Alex
- Re: [Qemu-devel] [PATCH v2 01/15] target-ppc: Fix PPC_DUMP_SPR_ACCESS build, (continued)
- [Qemu-devel] [PATCH v2 03/15] qemu-log: Introduce qemu_log_mask_vprintf(), Andreas Färber, 2013/02/20
- [Qemu-devel] [PATCH v2 10/15] target-microblaze: Refactor debug output macros, Andreas Färber, 2013/02/20
- [Qemu-devel] [PATCH v2 07/15] target-cris: Refactor debug output macros, Andreas Färber, 2013/02/20
- [Qemu-devel] [PATCH v2 09/15] target-lm32: Refactor debug output macros, Andreas Färber, 2013/02/20
- [Qemu-devel] [PATCH v2 06/15] target-alpha: Refactor debug output macros, Andreas Färber, 2013/02/20
- [Qemu-devel] [PATCH v2 08/15] target-i386: Refactor debug output macros, Andreas Färber, 2013/02/20
- [Qemu-devel] [PATCH v2 12/15] target-ppc: Refactor debug output macros, Andreas Färber, 2013/02/20
- Re: [Qemu-devel] [PATCH v2 12/15] target-ppc: Refactor debug output macros,
Alexander Graf <=
- [Qemu-devel] [PATCH v2 05/15] target-cris/mmu.c: Update Coding Style of cris_mmu_translate_page(), Andreas Färber, 2013/02/20
- [Qemu-devel] [PATCH v2 11/15] target-openrisc: Refactor debug output macros, Andreas Färber, 2013/02/20
- [Qemu-devel] [PATCH v2 04/15] target-cris/helper.c: Update Coding Style, Andreas Färber, 2013/02/20
- [Qemu-devel] [PATCH v2 14/15] target-sparc: Refactor debug output macros, Andreas Färber, 2013/02/20
- [Qemu-devel] [PATCH v2 15/15] target-unicore32: Refactor debug output macros, Andreas Färber, 2013/02/20
- [Qemu-devel] [PATCH v2 02/15] target-ppc: Move PPC_DUMP_CPU to translate.c, Andreas Färber, 2013/02/20