Re: [Qemu-devel] [PATCH v2] ui/gtk: require at least GTK 2.18 and VTE 0.26

[Stefan Weil]

Am 22.02.2013 16:50, schrieb Anthony Liguori:
> This gives us the bare amount of features we need.  We can add work arounds
> for older versions and lower the requirement but this should be a good
> starting point.
>
> Suggested-by: Daniel Berrange <address@hidden>
> Signed-off-by: Anthony Liguori <address@hidden>
> ---
> v1 -> v2
>  - tremendous simplification suggested by danpb
> ---
>  configure | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index 0dadd31..0eb25dd 100755
> --- a/configure
> +++ b/configure
> @@ -1644,8 +1644,8 @@ fi
>  # GTK probe
>  
>  if test "$gtk" != "no"; then
> -    if $pkg_config gtk+-2.0 --modversion >/dev/null 2>/dev/null && \
> -       $pkg_config vte --modversion >/dev/null 2>/dev/null; then
> +    if $pkg_config --exists 'gtk+-2.0 >= 2.18.0' && \
> +       $pkg_config --exists 'vte >= 0.26.0'; then

It's even possible to combine both checks in one :-)

--exists 'gtk+-2.0 >= 2.18.0 vte >= 0.26.0'

But we need a different solution because not all platforms
support VTE. It must be possible to use GTK without VTE,
so VTE needs its own section in configure.

>       gtk_cflags=`$pkg_config --cflags gtk+-2.0 2>/dev/null`
>       gtk_libs=`$pkg_config --libs gtk+-2.0 2>/dev/null`
>       vte_cflags=`$pkg_config --cflags vte 2>/dev/null`