Re: [Qemu-devel] [PATCH v7 5/5] block: Support GlusterFS as a QEMU block backend.

[Paolo Bonzini]

Il 20/09/2012 11:12, Bharata B Rao ha scritto:
>> > Perhaps it would be cleaner to make qemu_gluster_parseuri and
>> > parse_gluster_spec accept a const char *.  You can replace strtok_r +
>> > g_strdup with strspn/strcspn followed by g_strndup.
> I feel the current approach of using the combination of strncmp, strtok_r
> and g_strdup should be good enough.
> 
> But if you feel and insist that the right way to do this is to use the
> combination of strstart, strspn and g_strndup, I could give it a try.

I won't insist on anything :) but please check the delimiters as
mentioned in the other message.

Paolo