[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 2/2] Split fdd devices off the floppy contro
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [RFC PATCH 2/2] Split fdd devices off the floppy controller |
Date: |
Wed, 16 May 2012 22:09:26 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) |
Kevin Wolf <address@hidden> writes:
> Am 14.05.2012 13:58, schrieb Andreas Färber:
>> Am 14.05.2012 10:47, schrieb Kevin Wolf:
>>> Am 11.05.2012 17:22, schrieb Markus Armbruster:
>>>> For historical reasons, and unlike other block devices, our floppy
>>>> devices isa-fdc, sysbus-fdc and SUNW,fdtwo integrate the controller
>>>> and the drive(s) in a single qdev. This makes them weird: we need
>>>> -global to set up floppy drives, unlike every other optional device.
>>>
>>> I like the idea of splitting the drives from the controller. In fact, I
>>> think we could even try to split them into a separate hw/fdd.c
>>
>> Seconded, however that might make the patch harder to read due to the
>> code movements.
>
> I didn't mean that we should do it in this patch, of course, but as a
> second step.
Sounds like a plan.