Re: [Qemu-devel] [PATCH V2 0/4] MIPS ASE DSP Support for Qemu

[Jia Liu]

On Sat, Mar 24, 2012 at 12:01 AM, Richard Henderson <address@hidden> wrote:
>> +DEF_HELPER_1(absqsph, i32, i32)
>
> Many of these helpers merely compute a function.  They do not trap,
> they do not modify global state.  They should be using the
> DEF_HELPER_FLAGS_N macro to define them, so that the TCG compiler
> can optimize around the functions better.
>
>>  target-mips/op_helper.c | 3936 
>> +++++++++++++++++++++++++++++++++++++++++++++++
>>  1 files changed, 3936 insertions(+), 0 deletions(-)
>
> Nearly 4000 lines to me says: put these in their own file.
>
> It would be my preference if this were done in a way that
> exposes any implicit uses of the ENV variable.  But even
> failing that, the makefile can be adjusted to apply HELPER_CFLAGS
> to other helper files.
>

Thanks for comment, put these in their own file is a good idea.
I'll do it.

>
> r~