Re: [Qemu-devel] [PATCH 03/12] qemu-timer: more clock functions

[Lluís Vilanova]

Paolo Bonzini writes:

> On 09/30/2011 12:52 PM, Lluís Vilanova wrote:
>> Paolo Bonzini writes:
>> 
>>> These will be used when moving icount accounting to cpus.c.
>> 
>> I have something related to this kind of refactoring. While trying to 
>> understand
>> all the timing facilities in QEMU, I wrote some (unfinished) patches that 
>> try to
>> disentangle much of the code in qemu-timer into two new files:
>> 
>> - qemu-htime: Provides routines related to time in the host.
>> - qemu-vtime: Provides routines related to time in the guest.
>> 
>> These patches also try to sanitize some routine names by making their domain 
>> and
>> units explicit (e.g., get_clock becomes qemu_htime_nsec and cpu_get_ticks
>> becomes qemu_vtime_tsc).

> That's almost unnecessary, get_clock should be just
> qemu_get_clock_ns(host_clock) or something like that.  The problem is that the
> clock names are impossible to remember. :)

Yes, that was the main point of my refactoring :)


> However, making it clear from the name whether get_clock refers to the
> host_clock or rt_clock can be a useful cleanup.

Well, then maybe I will resume that work after 1.0.


Lluis

-- 
 "And it's much the same thing with knowledge, for whenever you learn
 something new, the whole world becomes that much richer."
 -- The Princess of Pure Reason, as told by Norton Juster in The Phantom
 Tollbooth