[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 0/2] Replace 9p debug infrastructure with Qe
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [RFC PATCH 0/2] Replace 9p debug infrastructure with Qemu Tracing |
Date: |
Thu, 29 Sep 2011 18:16:51 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Thu, Sep 29, 2011 at 06:09:47PM +0530, Harsh Prateek Bora wrote:
> This patchset introduces Qemu Tracing to 9p pdu handlers and removes the
> existing debug infrastructure which becomes less meaningful after the
> introduction of coroutines. Parallel operations creates a messy output and
> filtering becomes difficult. With Qemu tracing in place, we can selectively
> enable/disable trace-events and the trace log can be further filtered using
> analysis scripts.
>
> Harsh Prateek Bora (2):
> Introduce tracing for 9p pdu handlers
> Remove virtio-9p-debug.* infra since we are using Qemu Tracing now.
>
> Makefile.objs | 2 +-
> hw/9pfs/virtio-9p-debug.c | 646
> ---------------------------------------------
> hw/9pfs/virtio-9p-debug.h | 6 -
> hw/9pfs/virtio-9p.c | 70 +++++-
> trace-events | 47 ++++
> 5 files changed, 110 insertions(+), 661 deletions(-)
> delete mode 100644 hw/9pfs/virtio-9p-debug.c
> delete mode 100644 hw/9pfs/virtio-9p-debug.h
Reviewed-by: Stefan Hajnoczi <address@hidden>
It would also be neat to wire up 9p pdu's to the pcap code in net/dump.c
so it's possible to capture 9p sessions and look at them with wireshark.
Stefan