[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V9 1/5] Support for TPM command line options
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH V9 1/5] Support for TPM command line options |
Date: |
Mon, 26 Sep 2011 22:03:47 +0300 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Mon, Sep 26, 2011 at 12:35:10PM -0400, Stefan Berger wrote:
> +void tpm_display_backend_drivers(FILE *out)
> +{
> + int i;
> +
> + fprintf(out, "Supported TPM types (choose only one):\n");
> +
> + for (i = 0; bes[i] != NULL; i++) {
> + fprintf(out, "%12s %s",
> + bes[i]->id, bes[i]->desc());
> + fprintf(out, "\n");
> + }
> + fprintf(out, "\n");
> +}
This dumps to stderr and so for qmp users it won't be correctly ordered.
I'd suggest simply using error_report. This means '?' goes to stderr,
not stdout, but that is consistent with e.g. -device '?'.
[Qemu-devel] [PATCH V9 4/5] Build the TPM frontend code, Stefan Berger, 2011/09/26
Re: [Qemu-devel] [PATCH V9 0/5] Qemu Trusted Platform Module (TPM) integration, Michael S. Tsirkin, 2011/09/26