|
| From: | Paolo Bonzini |
| Subject: | Re: [Qemu-devel] Tree broken by nbd: support feature negotiation commit. |
| Date: | Wed, 21 Sep 2011 09:32:13 +0200 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:6.0.2) Gecko/20110906 Thunderbird/6.0.2 |
On 09/21/2011 09:27 AM, Brad wrote:
Besides the obvious issue.. nbd.c:443: error: conflicting types for 'nbd_init' nbd.h:71: error: previous declaration of 'nbd_init' was here
Oops, thanks for pointing it out to me.
The changing of #ifndef _WIN32 to #ifdef __linux__ in nbd.c also looks questionable to me.
It is not portable code, and (unlike the rest of qemu-nbd and the block/nbd.c protocol) not meant to be portable. Are BLKROSET (defined in linux/fs.h) and the whole set of NBD ioctls available under OpenBSD?
Paolo
| [Prev in Thread] | Current Thread | [Next in Thread] |