[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 7/7] migration: qemu_savevm_iterate has three return
From: |
Juan Quintela |
Subject: |
[Qemu-devel] [PATCH 7/7] migration: qemu_savevm_iterate has three return values |
Date: |
Tue, 20 Sep 2011 15:24:46 +0200 |
We were retrying when there was one error, entering a loop.
Signed-off-by: Juan Quintela <address@hidden>
---
migration.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/migration.c b/migration.c
index 7f8928a..0baed23 100644
--- a/migration.c
+++ b/migration.c
@@ -362,6 +362,7 @@ void migrate_fd_connect(FdMigrationState *s)
void migrate_fd_put_ready(void *opaque)
{
FdMigrationState *s = opaque;
+ int ret;
if (s->state != MIG_STATE_ACTIVE) {
DPRINTF("put_ready returning because of non-active state\n");
@@ -369,7 +370,10 @@ void migrate_fd_put_ready(void *opaque)
}
DPRINTF("iterate\n");
- if (qemu_savevm_state_iterate(s->mon, s->file) == 1) {
+ ret = qemu_savevm_state_iterate(s->mon, s->file);
+ if (ret == -1) {
+ migrate_fd_error(s);
+ } else if (ret == 1) {
int old_vm_running = vm_running;
DPRINTF("done iterating\n");
--
1.7.6.2
- [Qemu-devel] [PATCH 0/7] Handle errors during migration, Juan Quintela, 2011/09/20
- [Qemu-devel] [PATCH 3/7] migration: Check that migration is active before cancel it, Juan Quintela, 2011/09/20
- [Qemu-devel] [PATCH 2/7] migration: only flush when there are no errors, Juan Quintela, 2011/09/20
- [Qemu-devel] [PATCH 1/7] migration: simplify state assignmente, Juan Quintela, 2011/09/20
- [Qemu-devel] [PATCH 7/7] migration: qemu_savevm_iterate has three return values,
Juan Quintela <=
- [Qemu-devel] [PATCH 6/7] migration: If there is one error, it makes no sense to continue, Juan Quintela, 2011/09/20
- [Qemu-devel] [PATCH 5/7] migration: add error handling to migrate_fd_put_notify()., Juan Quintela, 2011/09/20
- [Qemu-devel] [PATCH 4/7] savevm: avoid qemu_savevm_state_iterate() to return 1 when qemu file has error., Juan Quintela, 2011/09/20