Re: [Qemu-devel] [PATCH 2/2] vga: Fix portio list conversion fallouts

[Avi Kivity]

On 09/18/2011 10:07 PM, Jan Kiszka wrote:
> >  I don't think it should be deduplicated.  The device is providing two
> >  separate ABIs.
>
> Yes, two ABIs, and the only difference is the offset of the data register.

How about

#ifdef TARGET_I386
# define VBE_DATA_REG 1
#else
# define VBE_DATA_REG 2
#endif


> >
> >  Why disallow it?
>
> Did anyone check that something useful or at least valid comes out of
> the handlers when doing this so far impossible access?

It's a general problem.  It can't be fixed in devices, the core has to 
handle this (and devices have to tell it how to react to such accesses).

--
error compiling committee.c: too many arguments to function