[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 1/2] memory: Fix old portio word accesses
From: |
Jan Kiszka |
Subject: |
[Qemu-devel] [PATCH v2 1/2] memory: Fix old portio word accesses |
Date: |
Sun, 18 Sep 2011 14:51:58 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
From: Jan Kiszka <address@hidden>
As we register old portio regions via ioport_register, we are also
responsible for providing the word access wrapper.
Signed-off-by: Jan Kiszka <address@hidden>
---
Oops, was lacking a shift for word reads.
memory.c | 10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/memory.c b/memory.c
index b3ee232..aef4702 100644
--- a/memory.c
+++ b/memory.c
@@ -397,6 +397,11 @@ static void memory_region_iorange_read(IORange *iorange,
*data = ((uint64_t)1 << (width * 8)) - 1;
if (mrp) {
*data = mrp->read(mr->opaque, offset + mr->offset);
+ } else if (width == 2) {
+ mrp = find_portio(mr, offset, 1, false);
+ assert(mrp);
+ *data = mrp->read(mr->opaque, offset + mr->offset) |
+ (mrp->read(mr->opaque, offset + mr->offset + 1) << 8);
}
return;
}
@@ -419,6 +424,11 @@ static void memory_region_iorange_write(IORange *iorange,
if (mrp) {
mrp->write(mr->opaque, offset + mr->offset, data);
+ } else if (width == 2) {
+ mrp = find_portio(mr, offset, 1, false);
+ assert(mrp);
+ mrp->write(mr->opaque, offset + mr->offset, data & 0xff);
+ mrp->write(mr->opaque, offset + mr->offset + 1, data >> 8);
}
return;
}
--
1.7.3.4
- [Qemu-devel] [PATCH 1/2] memory: Fix old portio word accesses, Jan Kiszka, 2011/09/18
- [Qemu-devel] [PATCH v2 1/2] memory: Fix old portio word accesses,
Jan Kiszka <=
- Re: [Qemu-devel] [PATCH v2 1/2] memory: Fix old portio word accesses, Avi Kivity, 2011/09/18
- Re: [Qemu-devel] [PATCH v2 1/2] memory: Fix old portio word accesses, Jan Kiszka, 2011/09/18
- Re: [Qemu-devel] [PATCH v2 1/2] memory: Fix old portio word accesses, Avi Kivity, 2011/09/18
- Re: [Qemu-devel] [PATCH v2 1/2] memory: Fix old portio word accesses, Jan Kiszka, 2011/09/18
- Re: [Qemu-devel] [PATCH v2 1/2] memory: Fix old portio word accesses, Avi Kivity, 2011/09/18
- Re: [Qemu-devel] [PATCH v2 1/2] memory: Fix old portio word accesses, Jan Kiszka, 2011/09/18
- Re: [Qemu-devel] [PATCH v2 1/2] memory: Fix old portio word accesses, Avi Kivity, 2011/09/19
- Re: [Qemu-devel] [PATCH v2 1/2] memory: Fix old portio word accesses, Jan Kiszka, 2011/09/19
- Re: [Qemu-devel] [PATCH v2 1/2] memory: Fix old portio word accesses, Avi Kivity, 2011/09/19
- Re: [Qemu-devel] [PATCH v2 1/2] memory: Fix old portio word accesses, Jan Kiszka, 2011/09/19