Re: [Qemu-devel] [PATCH 0/3] Remove QEMUFile abuse

[malc]

On Fri, 16 Sep 2011, Anthony Liguori wrote:

> Reviewed-by: Anthony Liguori <address@hidden>
> 
> malc, please Ack.
> 

I don't like the commit message.

> 
> 
> On 09/13/2011 07:52 AM, Juan Quintela wrote:
> > Hi
> > 
> > QEMUFile is intended to be used only for migration.  Change the other
> > three users to use FILE * operations directly.  gcc on Fedora 15
> > complains about fread/write not checking its return value, so I added
> > checks.  But in several places only print an error message (there is
> > no error handly that I can hook into).  Notice that this is not worse
> > than it is today.
> > 
> > Later, Juan.
> > 
> > Juan Quintela (3):
> >    vawaudio: port to FILE*
> >    wavcapture: port to FILE*
> >    ds1225y: port to FILE*
> > 
> >   audio/wavaudio.c   |   28 +++++++++++++++++++---------
> >   audio/wavcapture.c |   38 +++++++++++++++++++++++++-------------
> >   hw/ds1225y.c       |   28 ++++++++++++++++------------
> >   3 files changed, 60 insertions(+), 34 deletions(-)
> > 
> 

-- 
mailto:address@hidden