[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] hw/integratorcp: Fix bugs in writes to CM_CT
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v2] hw/integratorcp: Fix bugs in writes to CM_CTRL system register |
Date: |
Fri, 16 Sep 2011 15:42:23 +0100 |
On 16 September 2011 15:08, Anthony Liguori <address@hidden> wrote:
> On 09/12/2011 09:43 AM, Peter Maydell wrote:
>>
>> Fix a number of bugs in the implementation of writes to the CM_CTRL
>> system register:
>> * write to cm_ctrl, not cm_init !
>> * an '&' vs '^' typo meant we would write the inverse of the bits
>> * handling the LED via printf() meant we spew lots of output
>> to stdout when Linux uses the LED as a heartbeat indicator
>> * we would hw_error() if a reset was requested rather than
>> actually resetting
>>
>> Signed-off-by: Peter Maydell<address@hidden>
>
> Applied. Thanks.
Thanks. (This is my 250th committed qemu patch, so a personal
milestone :-))
-- PMM