Re: [Qemu-devel] [PATCH 50/58] pseries: Update SLOF firmware image

[Peter Maydell]

On 14 September 2011 09:43, Alexander Graf <address@hidden> wrote:
> From: David Gibson <address@hidden>
>
> The current SLOF firmware for the pseries machine has a bug in SCSI
> condition handling that was exposed by recent updates to qemu's SCSI
> emulation.  This patch updates the SLOF image to one with the bug fixed.
>
> Signed-off-by: David Gibson <address@hidden>
> Signed-off-by: Alexander Graf <address@hidden>
> ---
>  pc-bios/README   |    2 +-
>  pc-bios/slof.bin |  Bin 579072 -> 578888 bytes
>  2 files changed, 1 insertions(+), 1 deletions(-)

I confess to not really understanding how we keep the git
submodules and the binary blobs in sync, but shouldn't there
be a reference in the commit message to the git commit hash
for the slof sources corresponding to this blob, and maybe
also an update to roms/SLOF here? (cf commit d67c3f2c for
example) ?

-- PMM