Re: [Qemu-devel] [PATCH] tcg/arm: Remove unused tcg_out_addi()

[Stefan Weil]

Am 12.09.2011 12:03, schrieb Peter Maydell:
> Remove the unused function tcg_out_addi() from the ARM TCG backend;
> this fixes a compilation failure on ARM hosts with newer gcc.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> A previous patch from Richard Henderson for this compile failure:
> http://patchwork.ozlabs.org/patch/110400/
> was rejected, so here's another go. This simply removes the unused 
> function,
> in line with the approach taken for ppc/ppc64 in commits 1a2eb162414 and
> c24a9c6ef94.
>
> If this is accepted I can do the equivalent patches for tcg/ia64 and 
> tcg/s390
> (although those don't cause compile failures because the unused function
> happens to be marked 'inline'.)
>
> tcg/arm/tcg-target.c | 15 ---------------
> 1 files changed, 0 insertions(+), 15 deletions(-)

Are you sure that those functions will never be needed again?
If yes, your solution is ok. I was not sure - that's the reason
why I had sent a patch using inline. #if 0 ... #endif and
a comment might also be a solution for possible
future usage.

Stefan