Re: [Qemu-devel] [PATCH] memory: simple memory tree printer

[Avi Kivity]

On 09/12/2011 01:37 PM, Gerd Hoffmann wrote:
> > I/O
> > io addr 0000000000000000 off 0000000000000000 size 10000
> > -e1000-io addr 000000000000c000 off 0000000000000000 size 40
> > -piix-bmdma-container addr 000000000000c040 off 0000000000000000 size 10
> > --bmdma addr 000000000000000c off 0000000000000000 size 4
> > --piix-bmdma addr 0000000000000008 off 0000000000000000 size 4
> > --bmdma addr 0000000000000004 off 0000000000000000 size 4
> > --piix-bmdma addr 0000000000000000 off 0000000000000000 size 4
> > -pci-conf-data addr 0000000000000cfc off 0000000000000000 size 4
> > -pci-conf-idx addr 0000000000000cf8 off 0000000000000000 size 4
>
> Could you put the (variable-length) name field last?  That should make 
> the whole list more readable as the addresses are aligned then.

Makes sense.  Can adopt other features from /proc/iomem - like using 
start/end instead of start/length - makes it easier to see if an address 
fits in a range.

--
error compiling committee.c: too many arguments to function