Re: [Qemu-devel] [PATCH v3 02/27] ide: Use a table to declare which drive kinds accept each command

[Markus Armbruster]

Kevin Wolf <address@hidden> writes:

> Am 06.09.2011 18:58, schrieb Markus Armbruster:
>> No functional change.
>> 
>> It would be nice to have handler functions in the table, like commit
>> e1a064f9 did for ATAPI.  Left for another day.
>> 
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>>  hw/ide/core.c |  105 
>> +++++++++++++++++++++++++++++++++++++++++++-------------
>>  1 files changed, 80 insertions(+), 25 deletions(-)
>
>> +    [IBM_SENSE_CONDITION]               = CFA_OK,
>> +    [CFA_WEAR_LEVEL]                    = CFA_OK,
>> +    [WIN_READ_NATIVE_MAX]               = ALL_OK,
>> +};
>> +
>> +static bool ide_cmd_permitted(IDEState *s, uint32_t cmd)
>> +{
>> +    return cmd <= ARRAY_SIZE(ide_cmd_table)
>
> Shouldn't it be < instead of <= ?

I plead temporary insanity.  Want a v4, or want to fix it up yourself?