[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 5/6] spice: set qxl->ssd.running=true before telling
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PATCH 5/6] spice: set qxl->ssd.running=true before telling spice to start, RHBZ #733993 |
Date: |
Wed, 7 Sep 2011 09:38:34 +0200 |
From: Yonit Halperin <address@hidden>
If qxl->ssd.running=true is set after telling spice to start, the spice server
thread can call qxl_send_events while qxl->ssd.running is still false. This
leads to
assert(d->ssd.running).
Signed-off-by: Yonit Halperin <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>
---
ui/spice-display.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/ui/spice-display.c b/ui/spice-display.c
index 4983963..e385361 100644
--- a/ui/spice-display.c
+++ b/ui/spice-display.c
@@ -260,11 +260,12 @@ void qemu_spice_vm_change_state_handler(void *opaque, int
running, int reason)
SimpleSpiceDisplay *ssd = opaque;
if (running) {
+ ssd->running = true;
qemu_spice_start(ssd);
} else {
qemu_spice_stop(ssd);
+ ssd->running = false;
}
- ssd->running = running;
}
void qemu_spice_display_init_common(SimpleSpiceDisplay *ssd, DisplayState *ds)
--
1.7.1
- [Qemu-devel] [PULL] spice patch queue, Gerd Hoffmann, 2011/09/07
- [Qemu-devel] [PATCH 3/6] qxl: send interrupt after migration in case ram->int_pending != 0, RHBZ #732949, Gerd Hoffmann, 2011/09/07
- [Qemu-devel] [PATCH 1/6] spice-qemu-char.c: Use correct printf format char for ssize_t, Gerd Hoffmann, 2011/09/07
- [Qemu-devel] [PATCH 2/6] hw/qxl: Fix format string errors, Gerd Hoffmann, 2011/09/07
- [Qemu-devel] [PATCH 4/6] qxl: s/qxl_set_irq/qxl_update_irq/, Gerd Hoffmann, 2011/09/07
- [Qemu-devel] [PATCH 5/6] spice: set qxl->ssd.running=true before telling spice to start, RHBZ #733993,
Gerd Hoffmann <=
- [Qemu-devel] [PATCH 6/6] spice: workaround a spice server bug., Gerd Hoffmann, 2011/09/07
- Re: [Qemu-devel] [PULL] spice patch queue, Anthony Liguori, 2011/09/08