Re: [Qemu-devel] [PATCH 0/6] Device state visualization reloaded

[Luiz Capitulino]

On Fri, 26 Aug 2011 16:48:10 +0200
Jan Kiszka <address@hidden> wrote:

> More than one year ago I posted some patches to add a monitor command
> callend device_show. The purpose of that command is to dump the state of
> some qdev device based on its vmstate.
> 
> To improve the usability of that interface, the previous series also
> tried to create a canonical qdev tree path name format and even added
> monitor command expansion. That format created quite a few discussions,
> and we never came to some conclusion.
> 
> As device_show is still a useful tool for debugging but qdev structuring
> and addressing may significantly change in the near future, I decided to
> reanimate those patches while avoiding almost any change of the
> addressing scheme. The only one I propose is automatic ID assignment for
> anonymous devices so that any qdev device is in principle addressable
> (e.g. APIC and IO-APIC on x86).
> 
> As back then, device_show remains HMP-only to avoid any stable ABI
> issues around QMP.
> 
> CC: Luiz Capitulino <address@hidden>
> CC: Markus Armbruster <address@hidden>

This looks good to me and I'm willing to apply it. Only issue I'd like to see
resolved is the base64 encoder/decoder. This series introduces a new one,
while the guest agent uses glib's.

I think we should choose one of them and stick to it.

Any other objections apart from that? Markus?