[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 03/14] qapi: use middle mode in QMP server
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH 03/14] qapi: use middle mode in QMP server |
Date: |
Fri, 2 Sep 2011 13:57:31 -0300 |
On Fri, 02 Sep 2011 11:45:28 -0500
Anthony Liguori <address@hidden> wrote:
> On 09/02/2011 11:31 AM, Michael Roth wrote:
>
> >>> This ended up being a bit harder than I initially thought so I'd prefer
> >>> to delay this to another series so we can start converting commands to
> >>> QAPI ASAP.
> >>
> >> Fine with me.
> >
> > Same. Curious what the complications are though, I wouldn't mind looking
> > at it.
>
> The current dispatch and error checking logic in the QMP server scares
> me. It wasn't immediately obvious if just adding another else clause in
> the dispatch logic was enough.
It inherited HMP's distinction between "info" and "regular" commands plus
the arg_type thing.
IMO, the best thing to do is to let it alone for now, do the QAPI conversion
and then drop it in favor on the new server.